Clean up error handling in Newport XPS service#440
Merged
Conversation
ivalaginja
added
enhancement
Collaborator
Author
|
Just a ping to reviewers that this PR is ready for review. |
RemiSoummer
force-pushed
the
clean_up_error_hanling_XPS
branch
from
b1aa24d to
7221f74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handling was a bit ambiguous so I separated out an error if there is no correct env variable set, or if it can simply not import the required module.
Tested on hardware and I was able to trigger both error messages independently.